avantgardnerio commented on code in PR #3580:
URL: https://github.com/apache/arrow-datafusion/pull/3580#discussion_r976937931


##########
datafusion/proto/build.rs:
##########
@@ -61,8 +61,9 @@ fn build() -> Result<(), String> {
     let json = 
std::fs::read_to_string(out.join("datafusion.serde.rs")).unwrap();
     let mut file = std::fs::OpenOptions::new()
         .write(true)
+        .truncate(true)

Review Comment:
   This was key to use just one output file for either feature set and avoid 
combinatorial explosions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to