kmitchener commented on code in PR #3567:
URL: https://github.com/apache/arrow-datafusion/pull/3567#discussion_r976986619
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -120,13 +120,33 @@ impl std::fmt::Display for BinaryExpr {
}
}
+macro_rules! compute_decimal_op_dyn_scalar {
+ ($LEFT:expr, $RIGHT:expr, $OP:ident, $OP_TYPE:expr) => {{
+ let ll = $LEFT.as_any().downcast_ref::<Decimal128Array>().unwrap();
+ if let ScalarValue::Decimal128(Some(_), _, _) = $RIGHT {
+ Ok(Arc::new(paste::expr! {[<$OP _decimal_scalar>]}(
+ ll,
+ $RIGHT.try_into()?,
+ )?))
+ } else {
+ // when the $RIGHT is a NULL, generate a NULL array of $OP_TYPE
type
+ Ok(Arc::new(new_null_array($OP_TYPE, $LEFT.len())))
+ }
+ }};
+}
+
macro_rules! compute_decimal_op_scalar {
($LEFT:expr, $RIGHT:expr, $OP:ident, $DT:ident) => {{
- let ll = $LEFT.as_any().downcast_ref::<$DT>().unwrap();
- Ok(Arc::new(paste::expr! {[<$OP _decimal_scalar>]}(
- ll,
- $RIGHT.try_into()?,
- )?))
+ let ll = $LEFT.as_any().downcast_ref::<Decimal128Array>().unwrap();
+ if let ScalarValue::Decimal128(Some(_), _, _) = $RIGHT {
+ Ok(Arc::new(paste::expr! {[<$OP _decimal_scalar>]}(
+ ll,
+ $RIGHT.try_into()?,
+ )?))
+ } else {
Review Comment:
I don't think we need to. Those 2 decimal macros are used only in 1 place
each and include "decimal" in the name -- it'd be a clear mistake to use it for
any other datatype. This area could use some refactoring, but I wanted to get
this in and the kernels moved to arrow-rs then maybe revisit this whole module
(famous last words, right?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
