alamb opened a new pull request #8333: URL: https://github.com/apache/arrow/pull/8333
This PR removes (most of) the special case pretty printing code in sql.rs in favor of the standard pretty printer and in the process adds support for DictionaryArray printing as well as standardizing how tests are run and output is compared in sql.rs, but I think the change is an improvement What I really want is support for `DictionaryArray` printing in sql.rs so I can write tests for that feature. This specific PR's change is larger than strictly necessary, so if people prefer, I could instead add a special case for `DictionaryArray`, but I felt this change would be better long term. Using `Vec<Vec<String>>` to encode expected results rather than a `String` retains the nice property that differences to expected output are shown reasonably in the test output. This relies on https://github.com/apache/arrow/pull/8331 and https://github.com/apache/arrow/pull/8332 so leaving it as a draft until that is complete ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
