milesgranger commented on code in PR #14106:
URL: https://github.com/apache/arrow/pull/14106#discussion_r977525067
##########
cpp/src/arrow/compute/kernels/scalar_cast_extension.cc:
##########
@@ -42,14 +42,17 @@ Status CastToExtension(KernelContext* ctx, const ExecSpan&
batch, ExecResult* ou
std::shared_ptr<CastFunction> GetCastToExtension(std::string name) {
auto func = std::make_shared<CastFunction>(std::move(name), Type::EXTENSION);
- for (auto types : {IntTypes(), FloatingPointTypes(), StringTypes(),
BinaryTypes()}) {
+ for (auto types : {PrimitiveTypes(), IntervalTypes(), TemporalTypes()}) {
for (auto in_ty : types) {
DCHECK_OK(
func->AddKernel(in_ty->id(), {in_ty}, kOutputTargetType,
CastToExtension));
}
}
- DCHECK_OK(func->AddKernel(Type::DICTIONARY, {InputType(Type::DICTIONARY)},
- kOutputTargetType, CastToExtension));
+ for (auto in_ty : {Type::DICTIONARY, Type::LIST, Type::LARGE_LIST,
+ Type::FIXED_SIZE_LIST, Type::EXTENSION}) {
Review Comment:
Updated in
https://github.com/apache/arrow/pull/14106/commits/29db94b04c8d5598002a4942088cd3a556ffae86.
Let me know if the `AllTypeIds` should rather be in a new file `type_fwd.cc`
or inlined as it is now in `type_fwd.h`.
@pitrou in another comment it was determined it ought to be okay to cast
from extension to extension. The implementation would first cast from the input
Extension to the target Extension's storage type, so long as those are
compatible, then to the final Extension type. Does that align with your view?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
