assignUser commented on code in PR #14155:
URL: https://github.com/apache/arrow/pull/14155#discussion_r977545534
##########
.github/workflows/cpp.yml:
##########
@@ -45,11 +45,12 @@ concurrency:
group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
cancel-in-progress: true
+permissions:
+ contents: read
+
env:
ARROW_ENABLE_TIMING_TESTS: OFF
DOCKER_VOLUME_PREFIX: ".docker/"
- ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
- ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
Review Comment:
I have added the secrets to the run stages to, I don't think it is a huge
problem but it might cause spurious CI failures and the fix is easy 👍
##########
.github/workflows/cpp.yml:
##########
@@ -45,11 +45,12 @@ concurrency:
group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
cancel-in-progress: true
+permissions:
+ contents: read
+
env:
ARROW_ENABLE_TIMING_TESTS: OFF
DOCKER_VOLUME_PREFIX: ".docker/"
- ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
- ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
Review Comment:
I have added the secrets to the run stages too, I don't think it is a huge
problem but it might cause spurious CI failures and the fix is easy 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
