thisisnic commented on code in PR #14184: URL: https://github.com/apache/arrow/pull/14184#discussion_r977704422
########## r/R/dataset-scan.R: ########## @@ -53,6 +53,29 @@ #' query and returns an Arrow [Table]. #' @rdname Scanner #' @name Scanner +#' @examplesIf arrow_with_dataset() & arrow_with_parquet() +#' # Set up directory for examples +#' tf <- tempfile() +#' dir.create(tf) +#' on.exit(unlink(tf)) +#' +#' data <- dplyr::group_by(mtcars, cyl) Review Comment: Given we don't have dplyr as a dependency, could it be worth removing the `group_by()` call here, and manually specifying the `partitioning` argument to `write_dataset()` instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
