benibus commented on code in PR #14100:
URL: https://github.com/apache/arrow/pull/14100#discussion_r977892353
##########
cpp/src/arrow/json/test_common.h:
##########
@@ -99,7 +99,7 @@ struct GenerateImpl {
template <typename T>
enable_if_base_binary<T, Status> Visit(const T&) {
auto size = std::poisson_distribution<>{4}(e);
- std::uniform_int_distribution<uint16_t> gen_char(32, 127); // FIXME
generate UTF8
+ std::uniform_int_distribution<uint16_t> gen_char(32, 126); // FIXME
generate UTF8
Review Comment:
They're legal. It just seemed that the author meant to exclude non-printable
characters entirely (although [x00-x1f need to be escaped but x7f
doesn't](https://www.rfc-editor.org/rfc/rfc8259#section-7), apparently).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
