isidentical opened a new pull request, #3593:
URL: https://github.com/apache/arrow-datafusion/pull/3593
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Part of #3579.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
During sorting, when we receive a new record batch we try to allocate space
for it. This is done with the assumption that the result of this sort will
still be around, and we don't want to accidentally overflow the memory so we
have to keep track of it. But after the #3510, this assumption might not hold
for all cases (particularly when you have a `fetch` limit set on your sorting
operation) so we might be over-allocating memory and constantly spilling for no
good reason.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
This PR adds the logic for avoiding over-allocations by instructing the
memory manager to shrink after each partial sort with a limit.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
No, this should be an optimization.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
