mopcup commented on code in PR #13934:
URL: https://github.com/apache/arrow/pull/13934#discussion_r978343154
##########
r/src/compute.cpp:
##########
@@ -188,6 +188,15 @@ std::shared_ptr<arrow::compute::FunctionOptions>
make_compute_options(
return out;
}
+ if (func_name == "one" || func_name == "hash_one") {
+ // (TODO) FunctionOption for `hash_one` has not been implemented yet, so
Review Comment:
I forgot to remove the old comments, and there is no longer any reason to
separate the blocks, so I put them together with other Aggreate functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
