js8544 commented on code in PR #14216:
URL: https://github.com/apache/arrow/pull/14216#discussion_r978499650
##########
cpp/src/arrow/adapters/orc/adapter.cc:
##########
@@ -530,7 +530,7 @@ ORCFileReader::~ORCFileReader() {}
Result<std::unique_ptr<ORCFileReader>> ORCFileReader::Open(
const std::shared_ptr<io::RandomAccessFile>& file, MemoryPool* pool) {
- auto result = std::unique_ptr<ORCFileReader>(new ORCFileReader());
+ auto result = std::unique_ptr<ORCFileReader>(new ORCFileReader);
Review Comment:
Can't because ORCFileReader's ctor is private. This delete of () was by
mistake and I reverted it.
##########
cpp/src/arrow/flight/integration_tests/test_integration_server.cc:
##########
@@ -119,8 +119,8 @@ class FlightIntegrationTestServer : public FlightServerBase
{
auto flight = data->second;
*data_stream = std::unique_ptr<FlightDataStream>(
- new NumberingStream(std::unique_ptr<FlightDataStream>(new
RecordBatchStream(
- std::shared_ptr<RecordBatchReader>(new
RecordBatchListReader(flight))))));
+ new NumberingStream(std::unique_ptr<FlightDataStream>(
+ new
RecordBatchStream(std::make_shared<RecordBatchListReader>(flight)))));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
