rtpsw commented on PR #14207: URL: https://github.com/apache/arrow/pull/14207#issuecomment-1257219970
> @westonpace, any idea how to fix the [Windows linker error here](https://github.com/apache/arrow/actions/runs/3122413945/jobs/5064339466)? In the past I was able to fix this by adding `inline` but this time it didn't work. I suspect this is due to adding `Executor`, which is not a public symbol, in a constructor parameter as you requested. If so and we insist on exposing the IO executor, I see a couple of options to consider: 1. Make `Executor` a public symbol. I'm not sure what issues that might lead to. 2. Make `Executor` derive from a new type which would be a public symbol, and use this type in the constructor. This would lead to a not-so-pretty dynamic cast internally. 3. Expose one or more different (public-symbol) parameters that are used to internally setup the IO executor. This restricts the kind of IO executors that the caller may set up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
