AssHero commented on code in PR #3578:
URL: https://github.com/apache/arrow-datafusion/pull/3578#discussion_r979527700
##########
datafusion/optimizer/src/filter_push_down.rs:
##########
@@ -248,6 +249,128 @@ fn get_pushable_join_predicates<'a>(
.unzip()
}
+// examine OR clause to see if any useful clauses can be extracted and push
down.
Review Comment:
This transformation should extract at least one quals from each sub-clauses
of OR, else do nothing.
(A AND B) OR (C AND D)
will be transformed to
((A AND B) OR (C AND D)) AND (A OR C)
OR
((A AND B) OR (C AND D)) AND ((A AND B) OR C)
OR
do nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
