pitrou commented on code in PR #14224:
URL: https://github.com/apache/arrow/pull/14224#discussion_r979894657
##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -81,6 +94,48 @@ macro(define_option_string name description default)
endif()
endmacro()
+# Topological sort by Tarjan's algorithm.
+set(ARROW_BOOL_OPTION_DEPENDENCIES_TSORTED)
+macro(tsort_bool_option_dependencies_visit option_name)
+ if("${${option_name}_TSORT_STATUS}" STREQUAL "VISITING")
+ message(FATAL_ERROR "Cycled option dependency is detected: ${option_name}")
Review Comment:
```suggestion
message(FATAL_ERROR "Cyclic option dependency is detected:
${option_name}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]