tustvold commented on code in PR #2780:
URL: https://github.com/apache/arrow-rs/pull/2780#discussion_r980264027
##########
arrow/src/compute/kernels/aggregate.rs:
##########
@@ -124,10 +124,7 @@ where
.map(|i| unsafe { array.value_unchecked(i) })
.reduce(|acc, item| if cmp(&acc, &item) { item } else { acc })
} else {
- let null_buffer = array
- .data_ref()
- .null_buffer()
- .map(|b| b.bit_slice(array.offset(), array.len()));
+ let null_buffer = array.data_ref().null_buffer();
Review Comment:
There aren't very many uses of BitIndexIterator, and so I think we're ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
