bkietz commented on code in PR #14241:
URL: https://github.com/apache/arrow/pull/14241#discussion_r980457942
##########
cpp/src/arrow/type_traits.h:
##########
@@ -858,7 +858,7 @@ using enable_if_physical_floating_point =
///
/// \param[in] type_id the type-id to check
/// \return whether type-id is an integer type one
-static inline bool is_integer(Type::type type_id) {
+static constexpr inline bool is_integer(Type::type type_id) {
Review Comment:
Constexpr implies `inline` and should not need the `static` quailfier
```suggestion
constexpr bool is_integer(Type::type type_id) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
