kou commented on code in PR #14235:
URL: https://github.com/apache/arrow/pull/14235#discussion_r980617221
##########
r/configure:
##########
@@ -255,8 +255,8 @@ if [ $? -eq 0 ]; then
if arrow_built_with ARROW_S3; then
PKG_CFLAGS="$PKG_CFLAGS -DARROW_R_WITH_S3"
if [ "$BUNDLED_LIBS" != "" ]; then
- # We're depending on openssl/curl from the system, so they're not in the
bundled deps
- BUNDLED_LIBS="$BUNDLED_LIBS -lssl -lcrypto -lcurl"
+ # We're depending on openssl/curl/AWS SDK from the system, so they're
not in the bundled deps
+ BUNDLED_LIBS="$BUNDLED_LIBS -lssl -lcrypto -lcurl
-laws-cpp-sdk-identity-management -laws-cpp-sdk-sts
-laws-cpp-sdk-cognito-identity -laws-cpp-sdk-s3 -laws-cpp-sdk-core
-laws-c-event-stream -laws-checksums -laws-c-common"
Review Comment:
1. We need to add AWS SDK C++ related `-lXXX`s only when Apache Arrow C++ is
built with system AWS SDK C++ (If we can require `arrow.pc`, we can implement
it simply...)
2. We need to add AWS SDK C++ related `-lXXX`s before `-lssl -lcrypto
-lcurl` because AWS SDK C++ depend on `-lssl -lcrypto -lcurl`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
