niyue commented on code in PR #13041:
URL: https://github.com/apache/arrow/pull/13041#discussion_r980803518
##########
python/pyarrow/_flight.pyx:
##########
@@ -986,14 +986,18 @@ cdef class MetadataRecordBatchWriter(_CRecordBatchWriter):
----------
batch : RecordBatch
"""
+ cdef:
+ shared_ptr[const CKeyValueMetadata] custom_metadata
Review Comment:
I am not very familiar with arrow flight API, previously I want to enhance
`write_batch` here by allowing `custom_metadata` as a param, however, I find
there is already an API called `write_with_metadata` (in `_flight.pyx` as
well), so I am not sure if it is the right thing to do. So far this
`custom_metadata` in this API is always null. @pitrou Do you have any
suggestion here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
