pitrou commented on code in PR #13962:
URL: https://github.com/apache/arrow/pull/13962#discussion_r980955525
##########
c_glib/test/test-orc-file-reader.rb:
##########
@@ -185,8 +185,8 @@ def all_columns
test("select fields") do
require_gi_bindings(3, 2, 6)
@reader.field_indices = [1, 3]
- assert_equal(build_table("boolean1" => build_boolean_array([false,
true]),
- "short1" => build_int16_array([1024, 2048])),
+ assert_equal(build_table("byte1" => build_int8_array([1, 100]),
+ "int1" => build_int32_array([65536, 65536])),
Review Comment:
Let's keep code well-formatted here.
```suggestion
"int1" => build_int32_array([65536, 65536])),
```
##########
ruby/red-arrow/test/test-orc.rb:
##########
@@ -164,8 +164,8 @@ def pp_values(values)
]
end
assert_equal([
- ["boolean1: bool", [pp_values([false, true])]],
- ["short1: int16", [pp_values([1024, 2048])]],
+ ["byte1: int8", [pp_values([1, 100])]],
+ ["int1: int32", [pp_values([65536, 65536])]],
Review Comment:
Can you maintain indentation here?
##########
cpp/src/arrow/adapters/orc/adapter.cc:
##########
@@ -411,7 +411,7 @@ class ORCFileReader::Impl {
ARROW_RETURN_IF(*it < 0, Status::Invalid("Negative field index"));
include_indices_list.push_back(*it);
}
- opts->includeTypes(include_indices_list);
+ opts->include(include_indices_list);
Review Comment:
I'm ok on the principle to make this change, but I'm surprised that no test
had to be changed.
Can we add a C++ test with field inclusion and some nested types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
