tustvold commented on code in PR #2793:
URL: https://github.com/apache/arrow-rs/pull/2793#discussion_r981721820
##########
arrow-array/src/array/dictionary_array.rs:
##########
@@ -308,20 +308,13 @@ impl<K: ArrowPrimitiveType> DictionaryArray<K> {
/// Return an iterator over the keys (indexes into the dictionary)
pub fn keys_iter(&self) -> impl Iterator<Item = Option<usize>> + '_ {
- self.keys
Review Comment:
These checks make no sense as we have already validated the dictionary
offsets are non-negative
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
