pitrou commented on code in PR #14247:
URL: https://github.com/apache/arrow/pull/14247#discussion_r982265717


##########
dev/tasks/docs/github.linux.yml:
##########
@@ -44,23 +44,18 @@ jobs:
           ref: {{ default_branch|default("master") }}
           path: crossbow
           fetch-depth: 1
-      - name: Move docs
+      - name: Prepare docs
         run: |
           # build files are created by the docker user
           sudo chown -R ${USER}: build
-          PR_DIR=crossbow/docs/pr_docs/{{ pr_number }}
-          mkdir -p $PR_DIR
-          rsync -a --delete build/docs/ $PR_DIR
-      - name: Push changes
+          # These are only used while generating the page
+          rm -rf build/docs/.doctrees
+      - name: Upload preview to S3
+        env: 
+          AWS_ACCESS_KEY_ID: {{ '${{ secrets.CROSSBOW_DOCS_AWS_ACCESS_KEY_ID 
}}' }}

Review Comment:
   @assignUser Do you want to try @raulcd's suggestion?



##########
dev/tasks/docs/github.linux.yml:
##########
@@ -44,23 +44,18 @@ jobs:
           ref: {{ default_branch|default("master") }}
           path: crossbow
           fetch-depth: 1
-      - name: Move docs
+      - name: Prepare docs
         run: |
           # build files are created by the docker user
           sudo chown -R ${USER}: build
-          PR_DIR=crossbow/docs/pr_docs/{{ pr_number }}
-          mkdir -p $PR_DIR
-          rsync -a --delete build/docs/ $PR_DIR
-      - name: Push changes
+          # These are only used while generating the page
+          rm -rf build/docs/.doctrees
+      - name: Upload preview to S3
+        env: 
+          AWS_ACCESS_KEY_ID: {{ '${{ secrets.CROSSBOW_DOCS_AWS_ACCESS_KEY_ID 
}}' }}
+          AWS_SECRET_ACCESS_KEY: {{ '${{ 
secrets.CROSSBOW_DOCS_AWS_SECRET_ACCESS_KEY }}' }}
+          AWS_DEFAULT_REGION: us-east-2
+          BUCKET: s3://voltrondata-labs-crossbow-docs
         run: |
-          cd crossbow
-          git config --local user.name "Github Actions"
-          git config --local user.email 
"[email protected]"
-          
-          URL_PATH=pr_docs/{{ pr_number }}
-          URL=https://crossbow.voltrondata.com/$URL_PATH
-
-          git add docs/$URL_PATH
-          git commit -m "Add docs preview for PR {{ pr_number }}"
-          git push
-          echo ":open_book: You can find the preview here: $URL" >> 
$GITHUB_STEP_SUMMARY
+          aws s3 cp build/docs/ $BUCKET/pr_docs/{{ pr_number }}/ --recursive

Review Comment:
   Or perhaps only `build/docs/html` needs to be uploaded?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to