nealrichardson commented on code in PR #14243:
URL: https://github.com/apache/arrow/pull/14243#discussion_r982305385
##########
r/tools/nixlibs.R:
##########
@@ -215,7 +215,7 @@ determine_binary_from_stderr <- function(errs) {
# If we're here, we're on an older OS but with a newer compiler than gcc
4.8
# (we already checked), so it is possible to build with more features on.
# We just can't use our binaries because they were built with newer glibc.
- return(NULL)
+ return("centos-7")
Review Comment:
If we're doing this, can we delete the ubuntu-18.04 job and use the centos-7
one for those cases?
##########
dev/tasks/r/github.packages.yml:
##########
@@ -288,11 +281,18 @@ jobs:
if [[ "$DEVTOOLSET_VERSION" -gt 0 ]]; then
# enable the devtoolset version to use it
source /opt/rh/devtoolset-$DEVTOOLSET_VERSION/enable
+ mkdir -p ~/.R
+ echo "CXX17=g++ -std=g++17 -g -O2 -fpic" >> ~/.R/Makevars
Review Comment:
Should this be added to `ci/scripts/r_docker_configure.sh`? (Used here in
L271 above)
##########
ci/docker/centos-7-cpp.dockerfile:
##########
@@ -37,7 +41,7 @@ COPY ci/scripts/install_sccache.sh /arrow/ci/scripts/
RUN bash /arrow/ci/scripts/install_sccache.sh unknown-linux-musl /usr/local/bin
ENV PATH=/opt/cmake-${cmake}/bin:$PATH \
- CC=/usr/bin/gcc \
- CXX=/usr/bin/g++ \
+ CC=/opt/rh/devtoolset-8/root/usr/bin/cc \
+ CXX=/opt/rh/devtoolset-8/root/usr/bin/c++ \
EXTRA_CMAKE_FLAGS="-DCMAKE_C_COMPILER=$CC -DCMAKE_CXX_COMPILER=$CXX" \
Review Comment:
These might not be needed anymore, I think just using the devtoolset will be
enough. This was to force using the default system compilers for the gcc 4.8
builds/tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
