pitrou commented on code in PR #13635:
URL: https://github.com/apache/arrow/pull/13635#discussion_r982489543
##########
r/src/safe-call-into-r-impl.cpp:
##########
@@ -77,8 +89,9 @@ std::string TestSafeCallIntoR(cpp11::function
r_fun_that_returns_a_string,
}
});
- thread_ptr->join();
- delete thread_ptr;
+ if (thread.joinable()) {
Review Comment:
No need for the `if` here as the thread is always launched above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
