alamb commented on code in PR #3621:
URL: https://github.com/apache/arrow-datafusion/pull/3621#discussion_r982858143
##########
datafusion/optimizer/src/reduce_outer_join.rs:
##########
@@ -438,13 +449,13 @@ mod tests {
None,
)?
.filter(binary_expr(
- col("t1.b").gt(lit(10u32)),
+ cast(col("t1.b"), DataType::Int64).gt(lit(10u32)),
Review Comment:
I recommend adding a new test explicitly for the cast case (or at least
renaming the test) rather than modifying the existing one so it is clear that
the case is covered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
