vibhatha commented on code in PR #13687: URL: https://github.com/apache/arrow/pull/13687#discussion_r982972286
########## docs/source/python/compute.rst: ########## @@ -370,3 +370,133 @@ our ``even_filter`` with a ``pc.field("nums") > 5`` filter: :class:`.Dataset` currently can be filtered using :meth:`.Dataset.to_table` method passing a ``filter`` argument. See :ref:`py-filter-dataset` in Dataset documentation. + + +User-Defined Functions +====================== + +.. warning:: + This API is **experimental**. + +PyArrow allows defining and registering custom compute functions. +These functions can then be called from Python as well as C++ (and potentially +any other implementation wrapping Arrow C++, such as the R ``arrow`` package) +using their registered function name. + +To register a UDF, a function name, function docs, input types and +output type need to be defined. Using :func:`pyarrow.compute.register_scalar_function`, + +.. code-block:: python + + import numpy as np + + import pyarrow as pa + import pyarrow.compute as pc + + function_name = "numpy_gcd" + function_docs = { + "summary": "Calculates the greatest common divisor", + "description": + "Given 'x' and 'y' find the greatest number that divides\n" + "evenly into both x and y." + } + + input_types = { + "x" : pa.int64(), + "y" : pa.int64() + } + + output_type = pa.int64() + + def to_np(val): + if isinstance(val, pa.Scalar): + return val.as_py() Review Comment: I understand your point. That's why the description included that idea. We didn't change the UDF kernels since it was merged. So for the moment I will document what's missing from the current docs. cc @westonpace @pitrou What's the best? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org