jorisvandenbossche commented on code in PR #14273:
URL: https://github.com/apache/arrow/pull/14273#discussion_r983200522
##########
ci/scripts/python_wheel_macos_build.sh:
##########
@@ -96,25 +96,27 @@ cmake \
-DARROW_BUILD_SHARED=ON \
-DARROW_BUILD_STATIC=OFF \
-DARROW_BUILD_TESTS=OFF \
+ -DARROW_COMPUTE=ON \
+ -DARROW_CSV=ON \
-DARROW_DATASET=${ARROW_DATASET} \
Review Comment:
Should we just hardcode this to ON? (the ARROW_PYTHON=ON would have ensure
that) I don't think we want to create wheels without dataset enabled?
##########
ci/scripts/python_wheel_macos_build.sh:
##########
@@ -129,9 +131,9 @@ cmake \
-DCMAKE_INSTALL_PREFIX=${build_dir}/install \
-DCMAKE_OSX_ARCHITECTURES=${CMAKE_OSX_ARCHITECTURES} \
-DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD} \
- -DOPENSSL_USE_STATIC_LIBS=ON \
Review Comment:
This seems unrelated to the other changes. Can you give a short reasoning
for it?
##########
cpp/CMakePresets.json:
##########
@@ -117,17 +117,46 @@
"ARROW_GANDIVA": "ON"
}
},
+ {
+ "name": "features-python-minimal",
+ "inherits": [
+ "features-minimal"
+ ],
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_COMPUTE": "ON",
+ "ARROW_CSV": "ON",
+ "ARROW_FILESYSTEM": "ON",
+ "ARROW_JSON": "ON"
Review Comment:
I haven't yet used the presets myself, but shall we include `ARROW_DATASET`
here as well? (that was included with the previous `features-python` preset.
Maybe you can also keep the exact name to keep it working for people that
were using those presets?
cc @wjones127
##########
ci/scripts/python_wheel_manylinux_build.sh:
##########
@@ -89,31 +89,32 @@ pushd /tmp/arrow-build
# https://github.com/aws/aws-sdk-cpp/issues/1809 is fixed and vcpkg
# ships the fix.
cmake \
- -DARROW_BROTLI_USE_SHARED=OFF \
-DARROW_BUILD_SHARED=ON \
-DARROW_BUILD_STATIC=OFF \
-DARROW_BUILD_TESTS=OFF \
+ -DARROW_COMPUTE=ON \
+ -DARROW_CSV=ON \
-DARROW_DATASET=${ARROW_DATASET} \
+ -DARROW_DATASET=ON \
Review Comment:
```suggestion
-DARROW_DATASET=ON \
```
##########
docs/source/developers/python.rst:
##########
@@ -313,24 +313,26 @@ created above (stored in ``$ARROW_HOME``):
$ mkdir arrow/cpp/build
$ pushd arrow/cpp/build
-
$ cmake -DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
-DCMAKE_INSTALL_LIBDIR=lib \
-DCMAKE_BUILD_TYPE=Debug \
+ -DARROW_BUILD_TESTS=ON \
+ -DARROW_COMPUTE=ON \
+ -DARROW_CSV=ON \
-DARROW_DATASET=ON \
+ -DARROW_FILESYSTEM=ON \
+ -DARROW_HDFS=ON \
+ -DARROW_JSON=ON \
+ -DARROW_PARQUET=ON \
+ -DARROW_WITH_BROTLI=ON \
-DARROW_WITH_BZ2=ON \
- -DARROW_WITH_ZLIB=ON \
- -DARROW_WITH_ZSTD=ON \
-DARROW_WITH_LZ4=ON \
-DARROW_WITH_SNAPPY=ON \
- -DARROW_WITH_BROTLI=ON \
- -DARROW_PARQUET=ON \
+ -DARROW_WITH_ZLIB=ON \
+ -DARROW_WITH_ZSTD=ON \
-DPARQUET_REQUIRE_ENCRYPTION=ON \
- -DARROW_PYTHON=ON \
- -DARROW_BUILD_TESTS=ON \
..
- $ make -j4
- $ make install
+ $ cmake --build . --target install --config Debug
Review Comment:
For my understanding: is the `--config Debug` needed if you already use
`CMAKE_BUILD_TYPE=Debug` above?
And will this line also build in parallel?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
