liukun4515 commented on code in PR #3657:
URL: https://github.com/apache/arrow-datafusion/pull/3657#discussion_r983675108
##########
datafusion/optimizer/src/simplify_expressions.rs:
##########
@@ -510,15 +503,6 @@ impl<'a> ConstEvaluator<'a> {
return Ok(s);
}
- // TODO: https://github.com/apache/arrow-datafusion/issues/3582
- // TODO: https://github.com/apache/arrow-datafusion/issues/3556
- // Do the type coercion in the simplify expression
- // this is just a work around for removing the type coercion in the
physical phase
- // we need to support eval the result without the physical expr.
- // If we don't do the type coercion, we will meet the
- // https://github.com/apache/arrow-datafusion/issues/3556 when create
the physical expr
- // to try evaluate the result.
- let expr = expr.rewrite(&mut self.type_coercion_helper)?;
Review Comment:
remove the type coercion in the simplify expression, because of it was done
before this rule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
