tustvold commented on issue #2175: URL: https://github.com/apache/arrow-datafusion/issues/2175#issuecomment-1262554350
> A major problem is because it is trait, we do not have a way to compare or check whether two 'PhysicalExpr' equal or not. `as_any().downcast_ref<RepartitionExec>.is_some()` ? I do have a couple of concerns: * This will be a monumental amount of effort and downstream churn * Static typing is a double-edged sword, whilst it makes some code that needs to handle a specific set of things, significantly simpler, it makes other things that need to handle arbitrary things, significantly more complicated * My 2 cents from arrow-rs is that there are use-cases for static typing, but it becomes unwieldy incredibly fast and has a somewhat frustrating habit of blowing up compile times I think what would help convince me is a use-case that cannot be done with the current approach, a massive rework of the entire execution stack in the interest of ergonomics is a bit of a tough sell imo... That being said if people are happy to undertake this work, I'm not going to stand in the way of that :sweat_smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
