pgovind commented on a change in pull request #8348:
URL: https://github.com/apache/arrow/pull/8348#discussion_r499925085
##########
File path: csharp/src/Apache.Arrow/Arrays/StructArray.cs
##########
@@ -21,13 +21,13 @@ namespace Apache.Arrow
{
public class StructArray : Array
{
- private readonly List<Array> _fields;
+ private readonly IEnumerable<IArrowArray> _fields;
Review comment:
1. I agree. I had `Array` first, but I was forced to make it
`IArrowArray` because `RecordBatch.Column(i)` returns an `IArrowArray`. See
https://github.com/dotnet/spark/blob/7bcd2a5060e12ca993132f4986b2dfb4b07df94f/src/csharp/Microsoft.Spark.E2ETest/IpcTests/Sql/DataFrameTests.cs#L365.
When we refactor `IArrowArray` -> `ArrowArray`, this can change too.
2. Yeap, you're right. Removed it. It is unused at the moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
