liukun4515 opened a new pull request, #3662: URL: https://github.com/apache/arrow-datafusion/pull/3662
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> In order to the target of https://github.com/apache/arrow-datafusion/issues/3582, we need do the `type coercion` first. After done the `type coercion`, some of the expr will be wrapped by the `cast/try_cast`, the rule of `pre_cast_lit_in_comparison` will not work, so we should refactor it. For example: For this case `cast(left_expr as data_type) < lit(value as data_type)`, if the value can be converted to the type of left_expr, we can unwrap the cast for the expr `cast(left_expr as data_type)` and add cast to ` lit(value as data_type)` and get the new literal expr `cast(lit(value as data_type) as left_expr_data_type)`. Closes #3622 # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
