AlenkaF commented on code in PR #14275: URL: https://github.com/apache/arrow/pull/14275#discussion_r984292566
########## python/pyarrow/src/arrow/python/api.h: ########## @@ -17,14 +17,14 @@ #pragma once -#include "arrow_to_pandas.h" -#include "common.h" -#include "datetime.h" -#include "deserialize.h" -#include "helpers.h" -#include "inference.h" -#include "io.h" -#include "numpy_convert.h" -#include "numpy_to_arrow.h" -#include "python_to_arrow.h" -#include "serialize.h" +#include "arrow/python/arrow_to_pandas.h" +#include "arrow/python/common.h" +#include "arrow/python/datetime.h" +#include "arrow/python/deserialize.h" +#include "arrow/python/helpers.h" +#include "arrow/python/inference.h" +#include "arrow/python/io.h" +#include "arrow/python/numpy_convert.h" +#include "arrow/python/numpy_to_arrow.h" +#include "arrow/python/python_to_arrow.h" +#include "arrow/python/serialize.h" Review Comment: I can't make this to works as: 1. We would like to get rid of top level inlcudions (`#include "foo.h"`) in all the header files. 2. If I try to prepend `pyarrow/` (which we would like to prepend instead of `arrow/python`) to all inclusions except `api.h` and prepend `arrow/python/` to `python/pyarrow/src/pyarrow/api.h` and tell cmake to install the headers into `python/build/dist/include/pyarrow` or `python/build/dist/include/arrow/python` the complier gets stuck on a point of not finding `arrow/python/*` headers or vice versa. Sorry if I am confusing things. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
