carols10cents opened a new pull request #8354:
URL: https://github.com/apache/arrow/pull/8354


   @nevi-me This is one commit on top of 
https://github.com/apache/arrow/pull/8330 that I'm opening to get some feedback 
from you on about whether this will help with ARROW-10168. I *think* this will 
bring the Rust implementation more in line with C++, but I'm not certain.
   
   I tried removing the `#[ignore]` attributes from the `LargeArray` and 
`LargeUtf8` tests, but they're still failing because the schemas don't match 
yet-- it looks like [this 
code](https://github.com/apache/arrow/blob/b2842ab2eb0d7a7a633049a5591e1eaa254d4446/rust/parquet/src/arrow/array_reader.rs#L595-L638)
 will need to be changed as well.
   
   That `build_array_reader` function's code looks very similar to the code 
I've changed here, is there a possibility for the code to be shared or is there 
a reason they're separate?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to