nealrichardson commented on code in PR #14243:
URL: https://github.com/apache/arrow/pull/14243#discussion_r984537445
##########
dev/tasks/r/github.packages.yml:
##########
@@ -255,12 +253,7 @@ jobs:
- {image: "rocker/r-ver:4.0.0"} # ubuntu-20.04
- {image: "rocker/r-ver:3.6.3", libarrow_binary: "TRUE"} #
debian:buster (10)
- {image: "rstudio/r-base:4.1-bionic"} # ubuntu-18.04
- # TODO(ARROW-17594): re-enable this with the devtoolset for C++17
- #- {image: "rstudio/r-base:4.2-centos7"}
- # Even with devtoolset-8, binaries fail because glibc is older than
- # what we build with on ubuntu-18.04 (uncomment to see the error)
- # TODO(ARROW-16976): build binaries with older glibc
- # - {image: "rstudio/r-base:4.2-centos7", devtoolset: "8"}
+ - {image: "rstudio/r-base:4.2-centos7", devtoolset: "8"}
Review Comment:
Oh right, got it. This is the one that does `R CMD INSTALL --build`, so it
is building the package but not libarrow, so it still needs devtoolset for
C++17. But if you take the binary artifact from that, you can install it
without devtoolset?
Would be good to document this and add messaging in `configure` or
`build_arrow_static.sh` so that if someone is trying to install from source
with gcc 4.8, we tell them what they need to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
