nealrichardson commented on code in PR #14277:
URL: https://github.com/apache/arrow/pull/14277#discussion_r984613813
##########
r/tests/testthat/test-Array.R:
##########
@@ -1172,6 +1172,43 @@ test_that("as_arrow_array() default method errors", {
)
})
+test_that("as_arrow_array() works for blob::blob()", {
+ skip_if_not_installed("blob")
+
+ expect_equal(
+ as_arrow_array(blob::blob(as.raw(1:5))),
Review Comment:
Should we test with more than length-1 lists? How about missing data? Any
other corners of the `blob` implementation we need to be concerned with?
Should we assert that you actually get an Array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
