wjones127 commented on PR #57:
URL: https://github.com/apache/arrow-nanoarrow/pull/57#issuecomment-1263836885
The only thing I would consider changing is the wrapper character for
physical type for extensions (which IIUC isn't a type parameter and isn't quite
child data):
```r
print_schema(new_extension_type(int32(), "some.ext.name"))
#> some.ext.name{int32}
print_schema(new_extension_type(dictionary(), "some.ext.name"))
#> some.ext.name{dictionary(int32)<string>}
```
Everything else looks pretty good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
