askoa commented on code in PR #3669:
URL: https://github.com/apache/arrow-datafusion/pull/3669#discussion_r985078590
##########
datafusion/optimizer/src/simplify_expressions.rs:
##########
@@ -790,6 +791,43 @@ impl<'a, S: SimplifyInfo> ExprRewriter for Simplifier<'a,
S> {
right,
} if !info.nullable(&left)? && left == right => lit(1),
+ //
+ // Rules for Modulo
+ //
+
+ // A % null --> null
+ BinaryExpr {
+ left: _,
+ op: Modulo,
+ right,
+ } if is_null(&right) => *right,
+ // null % A --> null
+ BinaryExpr {
+ left,
+ op: Modulo,
+ right: _,
+ } if is_null(&left) => *left,
+ // A % 1 --> 0
+ BinaryExpr {
+ left,
+ op: Modulo,
+ right,
+ } if !info.nullable(&left)? && is_one(&right) => lit(0),
+ // A % A --> 0
+ BinaryExpr {
+ left,
+ op: Modulo,
+ right,
+ } if !info.nullable(&left)? && left == right => lit(0),
Review Comment:
Rather than removing, I think I can move the DivideByZero condition above `A
% A` so that code does not evaluate `A % A` if A is zero. I'll make that change
and update this PR. Let me know if you see any issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
