askoa commented on code in PR #3669:
URL: https://github.com/apache/arrow-datafusion/pull/3669#discussion_r985081437
##########
datafusion/optimizer/src/simplify_expressions.rs:
##########
@@ -1458,11 +1552,15 @@ mod tests {
// ----- Simplifier tests -------
// ------------------------------
- fn simplify(expr: Expr) -> Expr {
+ fn simplify_result(expr: Expr) -> Result<Expr> {
let schema = expr_test_schema();
let execution_props = ExecutionProps::new();
let info = SimplifyContext::new(vec![&schema], &execution_props);
- expr.simplify(&info).unwrap()
+ expr.simplify(&info)
+ }
+
+ fn simplify(expr: Expr) -> Expr {
Review Comment:
Removed new function and using `should_panic`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
