andygrove opened a new pull request, #3677: URL: https://github.com/apache/arrow-datafusion/pull/3677
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Related to https://github.com/apache/arrow-datafusion/issues/3651. Not sure if this can close that issue or not. # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> The proposal in https://github.com/apache/arrow-datafusion/issues/3651 is to change `ExecutionPlan` to be an enum instead of a trait. I am concerned that this may be very disruptive so why don't we add a new `PhysicalPlan` enum that people can optionally use to wrap an `ExecutionPlan`? # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Proof-of-concept of new enum for discussion: ```rust /// Enum representation of a physical plan pub enum PhysicalPlan { // TODO add all of DataFusion's operators Projection(Arc<dyn ExecutionPlan>), Filter(Arc<dyn ExecutionPlan>), HashJoin(Arc<dyn ExecutionPlan>), /// User-provided ExecutionPlan that is not part of the DataFusion crate Extension(Arc<dyn ExecutionPlan>), } ``` There are `Into` implementations so it is easy to convert between `Arc<dyn ExecutionPlan>` and `PhysicalPlan` enum. # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> No. This is not a breaking API change. <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
