mingmwang commented on code in PR #261:
URL: https://github.com/apache/arrow-ballista/pull/261#discussion_r985174106
##########
ballista/rust/scheduler/src/state/execution_graph.rs:
##########
@@ -110,6 +114,20 @@ pub struct ExecutionGraph {
output_partitions: usize,
/// Locations of this `ExecutionGraph` final output locations
output_locations: Vec<PartitionLocation>,
+ /// Task ID generator, generate unique TID in the execution graph
+ task_id_gen: usize,
+ /// Failed stage attempts, record the failed stage attempts to limit the
retry times.
+ /// Map from Stage ID -> Set<Stage_ATTPMPT_NUM>
+ failed_stage_attempts: HashMap<usize, HashSet<usize>>,
Review Comment:
> I don't get why we are saving a `HashSet` of attempts. Shouldn't it just
be `usize`?
The purpose of using HashSet is to record what are the exact distinct failed
attempts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
