maartenbreddels commented on a change in pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#discussion_r500084727



##########
File path: python/pyarrow/compute.py
##########
@@ -253,6 +255,68 @@ def match_substring(array, pattern):
                          MatchSubstringOptions(pattern))
 
 
+def split_pattern(array, pattern, max_splits=-1, reverse=False):

Review comment:
       I see that changed in #8163, nice work. But that would make the API less 
friendly, having to pass in the options, instead of having an argument with 
default parameters. If you are strongly in favor of this, I'm ok with it, I'm 
not sure how 'user friendly' the arrow API needs to be.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to