jonkeane commented on code in PR #13483:
URL: https://github.com/apache/arrow/pull/13483#discussion_r985836689
##########
ci/scripts/r_revdepcheck.sh:
##########
@@ -19,11 +19,40 @@
set -ex
: ${R_BIN:=R}
-
+: ${ARROW_REVDEP_WORKERS:=1)}
+: ${N_JOBS:=$(nproc)}
Review Comment:
Could you add a comment in here about what these control + why they are
separate (presumably because we want to build with multiple cores, but we can't
run targets with multiple workers, yeah?)?
##########
ci/scripts/r_revdepcheck.sh:
##########
@@ -19,11 +19,40 @@
set -ex
: ${R_BIN:=R}
-
+: ${ARROW_REVDEP_WORKERS:=1)}
+: ${N_JOBS:=$(nproc)}
source_dir=${1}/r
# cpp building dependencies
-apt install -y cmake
+apt update -y -q && \
+apt install -y \
+ cmake \
+ libbrotli-dev \
+ libbz2-dev \
+ libc-ares-dev \
+ libcurl4-openssl-dev \
+ libgflags-dev \
+ libgoogle-glog-dev \
+ liblz4-dev \
+ libprotobuf-dev \
+ libprotoc-dev \
+ libradospp-dev \
+ libre2-dev \
+ libsnappy-dev \
+ libssl-dev \
+ libthrift-dev \
+ libutf8proc-dev \
+ libzstd-dev \
+ nlohmann-json3-dev \
+ pkg-config \
+ protobuf-compiler \
+ python3-dev \
+ python3-pip \
+ python3-rados \
+ rados-objclass-dev \
+ rapidjson-dev \
+ tzdata \
+ wget
Review Comment:
I wonder if we could actually "just" call something like
https://github.com/apache/arrow/blob/master/dev/release/setup-ubuntu.sh and
then we don't have to have all of these copied over? We have them in a few
places already, though if my searching is right, most of them are in
dockerfiles for various OSes
##########
docker-compose.yml:
##########
@@ -1385,9 +1385,8 @@ services:
tz: ${TZ}
shm_size: *shm-size
environment:
- LIBARROW_DOWNLOAD: "true"
Review Comment:
I know it wasn't part of this PR, but should be bump the R version from
`r-rstudio-r-base-4.0-focal-revdepcheck`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
