alamb commented on code in PR #3688:
URL: https://github.com/apache/arrow-datafusion/pull/3688#discussion_r985938095
##########
datafusion/expr/src/binary_rule.rs:
##########
@@ -457,18 +449,18 @@ fn dictionary_coercion(
(
DataType::Dictionary(_lhs_index_type, lhs_value_type),
DataType::Dictionary(_rhs_index_type, rhs_value_type),
- ) => dictionary_value_coercion(lhs_value_type, rhs_value_type),
Review Comment:
Arrow now supports general purpose casting, so we can just call back into
the general comparison coercion code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
