alamb commented on code in PR #3692:
URL: https://github.com/apache/arrow-datafusion/pull/3692#discussion_r985987313
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -107,8 +134,35 @@ pub struct Optimizer {
}
impl Optimizer {
+ /// Create a new optimizer using the recommended list of rules
+ pub fn new(config: &OptimizerConfig) -> Self {
+ let mut rules: Vec<Arc<dyn OptimizerRule + Sync + Send>> = vec![
+ Arc::new(TypeCoercion::new()),
+ Arc::new(SimplifyExpressions::new()),
+ Arc::new(UnwrapCastInComparison::new()),
+ Arc::new(DecorrelateWhereExists::new()),
+ Arc::new(DecorrelateWhereIn::new()),
+ Arc::new(ScalarSubqueryToJoin::new()),
+ Arc::new(SubqueryFilterToJoin::new()),
+ Arc::new(EliminateFilter::new()),
+ Arc::new(ReduceCrossJoin::new()),
+ Arc::new(CommonSubexprEliminate::new()),
+ Arc::new(EliminateLimit::new()),
+ Arc::new(ProjectionPushDown::new()),
+ Arc::new(RewriteDisjunctivePredicate::new()),
+ ];
+ if config.filter_null_keys {
+ rules.push(Arc::new(FilterNullJoinKeys::default()));
+ }
+ rules.push(Arc::new(ReduceOuterJoin::new()));
+ rules.push(Arc::new(FilterPushDown::new()));
+ rules.push(Arc::new(LimitPushDown::new()));
+ rules.push(Arc::new(SingleDistinctToGroupBy::new()));
+ Self::with_rules(rules)
+ }
+
/// Create a new optimizer with the given rules
- pub fn new(rules: Vec<Arc<dyn OptimizerRule + Send + Sync>>) -> Self {
+ pub fn with_rules(rules: Vec<Arc<dyn OptimizerRule + Send + Sync>>) ->
Self {
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
