amoeba opened a new pull request, #14330:
URL: https://github.com/apache/arrow/pull/14330
I could use some help with a couple of things:
1. `devtools::check` warns about `pull.ArrowTabluar` being undocumented. I
`@export`ed it to stay consistent with other ArrowTabular generics defined in
`arrow-tabular.R` and don't understand why checking doesn't warn on all of
these. Does this one just not need exporting?
<details>
<summary>Relevant devtools::check() output</summary>
```
❯ checking for missing documentation entries ... WARNING
Undocumented code objects:
‘pull.ArrowTabular’
All user-level objects in a package should have documentation entries.
See chapter ‘Writing R documentation files’ in the ‘Writing R
Extensions’ manual.
```
</details>
2. I found an inconsistency with `dplyr::pull` and Tables: Pulling an
ungrouped Table produces a ChunkedArray whereas pulling a grouped Table
produces a Table. This makes a subsequent call to `as.vector` produce an error
of `Error in as.vector(x, mode) : cannot coerce type 'environment' to vector of
type 'any'`
<details>
<summary>Example of the difference</summary>
```r
> sw_table <- arrow_table(starwars)
> sw_table |>
+ filter(height > 100) |>
+ group_by(homeworld) |>
+ pull(name) |>
+ class()
[1] "Table" "ArrowTabular" "ArrowObject" "R6"
> sw_table |>
+ filter(height > 100) |>
+ pull(name) |>
+ class()
[1] "ChunkedArray" "ArrowDatum" "ArrowObject" "R6"
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
