liukun4515 commented on code in PR #3721:
URL: https://github.com/apache/arrow-datafusion/pull/3721#discussion_r988578925


##########
datafusion/optimizer/src/type_coercion.rs:
##########
@@ -398,6 +398,20 @@ impl ExprRewriter for TypeCoercionRewriter {
                     }
                 }
             }
+            Expr::ScalarFunction { fun, args } => match fun {
+                BuiltinScalarFunction::Concat
+                | BuiltinScalarFunction::ConcatWithSeparator => {
+                    let new_args = args

Review Comment:
   Is there type coercion rule for the function `Concat` or 
`ConcatWithSeparator`?
   
   Now the type coercion are not supported in the logical phase for some expr 
which is `Expr::ScalarFunction`, 
`Expr::AggregateFunction`,`Expr::WindowFunction` and `Expr::AggregateUDF` in 
the follow-up pr for this 
https://github.com/apache/arrow-datafusion/issues/3582#issuecomment-1254441358



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to