alamb commented on code in PR #3728: URL: https://github.com/apache/arrow-datafusion/pull/3728#discussion_r988222263
########## datafusion/expr/src/type_coercion/binary.rs: ########## @@ -17,6 +17,7 @@ //! Coercion rules for matching argument types for binary operators Review Comment: I renamed `binary_rule.rs` to `type_coercion/binary.rs` to better explain what it is for. I have always been confused about the name `binary_rule` I think this module has a lot more code than for binary operators so it can be split / cleaned up more but I felt this is a good start -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
