wgtmac commented on code in PR #14147:
URL: https://github.com/apache/arrow/pull/14147#discussion_r989044314
##########
cpp/src/parquet/encoding.cc:
##########
@@ -1146,15 +1146,11 @@ int PlainDecoder<DType>::Decode(T* buffer, int
max_values) {
return max_values;
}
-class PlainBooleanDecoder : public DecoderImpl,
- virtual public TypedDecoder<BooleanType>,
- virtual public BooleanDecoder {
+class PlainBooleanDecoder : public DecoderImpl, virtual public
TypedDecoder<BooleanType> {
public:
explicit PlainBooleanDecoder(const ColumnDescriptor* descr);
void SetData(int num_values, const uint8_t* data, int len) override;
- // Two flavors of bool decoding
- int Decode(uint8_t* buffer, int max_values) override;
Review Comment:
> See [#14147
(comment)](https://github.com/apache/arrow/pull/14147#discussion_r977099469) .
Could you share your downstream code that uses this?
>
> @sfc-gh-nthimmegowda Can we keep backward compatibility for this?
It pretty straight-forward. The downstream code can use a vector of uint8_t
instead of bool to hold a vector of decoded boolean values.
@sfc-gh-nthimmegowda Thanks for keeping backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
