pitrou commented on code in PR #14335:
URL: https://github.com/apache/arrow/pull/14335#discussion_r989103984
##########
dev/archery/archery/docker/core.py:
##########
@@ -378,7 +378,12 @@ def run(self, service_name, command=None, *, env=None,
volumes=None,
else:
cmd = service.get('command', '')
if cmd:
- args.extend(shlex.split(cmd))
+ # service command might be already defined as a list
+ # on the docker-compose yaml file.
+ if isinstance(cmd, list):
+ cmd = shlex.join(cmd)
+ else:
Review Comment:
Why the "else"? You must still extend the args after joining the command
list...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
