tustvold commented on code in PR #2830:
URL: https://github.com/apache/arrow-rs/pull/2830#discussion_r989214673
##########
arrow/src/datatypes/native.rs:
##########
@@ -46,6 +46,7 @@ pub(crate) mod native_op {
+ Div<Output = Self>
+ Rem<Output = Self>
+ Zero
+ + num::ToPrimitive
Review Comment:
Oh I see, could we possibly have the dyn_scalar kernels just have the
constraint on `ToPrimitive + ArrowNativeTypeOp` instead of unifying them.
This not only avoids this leaking to the arithmetic kernels, which will
complicate porting decimals over, but it also seems wrong that the dyn kernels
are performing type coercion on the scalar value at all, and I would like to
keep the door open to removing this down the line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
