alamb commented on code in PR #3719:
URL: https://github.com/apache/arrow-datafusion/pull/3719#discussion_r989362810
##########
datafusion/optimizer/src/simplify_expressions.rs:
##########
@@ -950,6 +950,24 @@ macro_rules! assert_contains {
};
}
+/// Apply simplification and constant propagation to ([Expr]).
+///
+/// # Arguments
+///
+/// * `expr` - The logical expression
+/// * `schema` - The DataFusion schema for the expr, used to resolve `Column`
references
+/// to qualified or unqualified fields by name.
+/// * `props` - The Arrow schema for the input, used for determining
expression data types
+/// when performing type coercion.
+pub fn simplify_expr(
+ expr: Expr,
+ schema: DFSchemaRef,
Review Comment:
While working on https://github.com/apache/arrow-datafusion/pull/3741 I
found having a signature of `schema: &DFSchemaRef` was actually more ergnonmic.
What do you think?
We have to rerun the CI anyways give the github nonsense earlier today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
