zeroshade commented on code in PR #14255: URL: https://github.com/apache/arrow/pull/14255#discussion_r989482562
########## go/arrow/compute/internal/kernels/_lib/types.h: ########## @@ -0,0 +1,368 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// corresponds to datatype.go's arrow.Type +enum class arrtype : int { + NULL, + BOOL, + UINT8, + INT8, + UINT16, + INT16, + UINT32, + INT32, + UINT64, + INT64, + FLOAT16, + FLOAT32, + FLOAT64 +}; + + +#define _LIBCPP_TEMPLATE_VIS +#define _LIBCPP_CONSTEXPR constexpr +#define _LIBCPP_INLINE_VISIBILITY +#define _LIBCPP_STD_VER 17 +#define _LIBCPP_NODEBUG +#define _LIBCPP_HAS_NO_CHAR8_T +#define _NOEXCEPT noexcept +#define _NOEXCEPT_(x) noexcept(x) + +// copied from libcxx/include/__type_traits/integral_constant.h Review Comment: We can't because we use a target of `x86_64-unknown-none` so it doesn't have the include paths to the standard c++ headers like type_traits, only C-headers as far as I can tell. Trying to pass the include paths directly ran into other issues. I can try mucking about with the makefile even more, but doing it this way makes the generation of the assembly more consistent and reproducible. After a few days trying to get around the seeming inability to portably get it to compile with `<type_traits>` this seemed to be the better path to take. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
